Moving clinical research elements to specimenPrep - #14
Draft
Peyman-N wants to merge 3 commits into
Draft
Conversation
Peyman-N
marked this pull request as ready for review
August 5, 2024 12:37
lzehl
requested changes
Sep 24, 2024
lzehl
left a comment
lzehl
left a comment
Member
There was a problem hiding this comment.
TBD : current state does not fit yet
| "type": "array", | ||
| "uniqueItems": true | ||
| }, | ||
| "behavioralProtocol": { |
Member
There was a problem hiding this comment.
this does not make sense here. please remove
| "assessment": { | ||
| "_instruction": "Add All the assessments aquired during this session.", | ||
| "_linkedTypes": [ | ||
| "https://openminds.ebrains.eu/specimenPrep/Assessment" |
Member
There was a problem hiding this comment.
TBD: I do not think this is a separate schema
Member
There was a problem hiding this comment.
most likely this will be a behavioral protocol
| @@ -0,0 +1,21 @@ | |||
| { | |||
| "_extends": "/publications/schemas/creativeWork.schema.tpl.json", | |||
| "_type": "https://openminds.ebrains.eu/specimenPrep/AssessmentInstrument", | |||
Member
There was a problem hiding this comment.
type mismatches type of filename and of reference in the other schema. Plus: I don't think this is a separate schema. Questionnaires or behavioral assessments are captured in behavioral protocols.
| @@ -0,0 +1,36 @@ | |||
| { | |||
| "_extends": "/core/schemas/research/experimentalActivity.schema.tpl.json", | |||
| "_type": "https://openminds.ebrains.eu/specimenPrep/SubjectPreparation", | |||
Member
|
Note: this PR should be updated after the merge of #15 |
lzehl
marked this pull request as draft
March 11, 2026 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.